zqr10159 commented on PR #4281: URL: https://github.com/apache/hertzbeat/pull/4281#issuecomment-5179619284
Addressed the review findings in commit `65977a3462`. Changes: - dynamic service-discovery credential validation now resolves the `monitor.scrape` definition rather than the monitored application; - legacy-default-key ciphertext is recognized and is not encrypted a second time; - public API DTOs remain masked, while configuration export uses a separate ciphertext-preserving path so same-secret export/import never needs plaintext; - the historical credential migration now writes a version marker and does not rescan the full parameter table on every startup. Human validation: - focused migration, validator, monitor service/controller, and JSON import/export suites (57 tests passed); - `git diff --check`. The new-head backend, Maven E2E, license, docs, and label checks are currently queued by GitHub and have not started yet. AI assistance: used for draft implementation and test iteration. Risk notes: encrypted exports remain tied to the deployment secret by design. @Duansg, please re-review this head when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
