zqr10159 commented on PR #4286: URL: https://github.com/apache/hertzbeat/pull/4286#issuecomment-5179619720
Addressed the review findings in commit `b87ff44df7`. Changes: - VictoriaMetrics collision validation now runs once per incoming batch instead of allocating/revalidating for every emitted sample; - single-node and cluster VictoriaMetrics storage count rejected collision batches and include the cumulative count in value-free diagnostics; - Greptime now uses the same explicit reject policy for custom labels that collide with `instance`, `ts`, or metric fields instead of silently skipping them; - non-conflicting Greptime custom tags remain supported. Human validation: - full `VictoriaMetricsDataStorageTest,GreptimeDbDataStorageTest` suites passed; - focused collision and allowed-label contracts passed; - `git diff --check`. The new-head backend, Maven E2E, license, docs, and label checks are currently queued by GitHub and have not started yet. AI assistance: used for draft implementation and test iteration. Risk notes: collision rejection is intentionally observable and batch-scoped; it does not rewrite or namespace user labels. @Duansg, please re-review this head when convenient. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
