fas89 opened a new pull request, #4298: URL: https://github.com/apache/hertzbeat/pull/4298
## What's changed? The realtime log threshold form uses three i18n keys that only exist in `zh-CN.json`: - `alert.setting.window` — required field label - `alert.setting.window.tip` — tooltip - `alert.setting.window.placeholder` — input placeholder They are referenced in `alert-setting.component.html` (the `*ngIf="define.type === 'realtime_log'"` form item) and were introduced together with the log alerting UI in #3985, but were only added to `zh-CN.json`. `I18NService.use()` assigns `this._data = this.flatData(data, [])`, replacing the translation map wholesale on language switch, so there is no cross-language fallback. On `en-US`, `ja-JP`, `ko-KR`, `pt-BR` and `zh-TW` the pipe returns the key itself and users see the raw string `alert.setting.window` as a required form label. This PR adds the three keys to the remaining five locales, following the wording and style of the neighbouring `alert.setting.period.*` entries in each file. Native speakers of ja/ko/zh-TW/pt-BR are very welcome to correct the phrasing — happy to amend. ## Checklist - [x] I have read the [Contributing Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide) - [x] I have written the necessary doc or comment. - [ ] I have added the necessary unit tests and all cases have passed. — no tests added, this changes translation resource files only. Verified all six locale files still parse as valid JSON and the three keys now resolve in every locale. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
