zqr10159 commented on PR #4288: URL: https://github.com/apache/hertzbeat/pull/4288#issuecomment-5133337167
Author validation update: Basic authentication was not removed. Every Grafana request still uses createHeaders(), which builds the Authorization Basic header from the configured username and password. The removed code was only a second persistent BasicAuthenticationInterceptor on the shared RestTemplate, which accumulated credentials across requests. This was verified against a real Grafana 13.1.1 instance using a real RestTemplate: listing service accounts, creating the HertzBeat service account, and issuing its token all succeeded. Focused tests passed (4 plus one temporary live smoke), all current GitHub checks are green, and the temporary Grafana test and runtime artifacts were not committed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
