zqr10159 opened a new pull request, #4294:
URL: https://github.com/apache/hertzbeat/pull/4294

   ## What changed?
   
   - add HMAC-SHA256 metadata to the cluster message envelope;
   - sign manager and standalone collector traffic with their locally 
configured common secret;
   - reject modified, stale, unsigned, and replayed messages before processor 
dispatch;
   - keep a bounded five-minute replay window;
   - cover the real loopback Netty request/response path.
   
   This is a dependent follow-up to #4263. It intentionally builds on that PR 
so the AES key is configured locally before the remoting client starts.
   
   ## Compatibility and rollout
   
   Manager and standalone Collector must be upgraded together, use the same 
common.secret value, and keep their clocks within five minutes. Merge #4263 
first, or retarget this PR to master after #4263 lands.
   
   ## Validation
   
   - ClusterMessageAuthenticatorTest and NettyRemotingAuthenticationTest: 4 
tests passed.
   - RemotingServiceTest: 3 signed loopback Netty tests passed.
   - CollectServerTest, ManageServerTest, CollectorOnlineProcessorTest, and 
CollectorJobSchedulerTest: 16 tests passed.
   - Selected 22-module Maven reactor, Checkstyle, and diff checks passed.
   
   AI assistance: used for draft implementation and test iteration.
   Human validation: focused remoting, collector, and manager Maven reactors 
passed; signed loopback Netty traffic was exercised.
   Risk notes: this is a protocol contract change; mixed-version 
manager/collector pairs are intentionally rejected. Deployments must 
synchronize common.secret and system time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to