orangeCatDeveloper opened a new pull request, #4185:
URL: https://github.com/apache/hertzbeat/pull/4185

   ## What's changed?
   
   Fix unbalanced/malformed HTML markup in the i18n `help:` field of 14 
monitoring templates: missing closing `</span>`, an orphan `</span>` with no 
matching open tag, a malformed `<a href>` in nacos ja-JP that broke the 
attribute value, `< span` (extra space) typos, and stray trailing `"` 
characters left in four templates' `en-US` values.
   
   The nacos ja-JP one is user-visible: the broken `href` attribute swallows 
the rest of the help text in a real browser, so users only ever see the text up 
to "事前に". Screenshots from the actual add-monitor page, before/after:
   
   **Before**
   
![before](https://raw.githubusercontent.com/orangeCatDeveloper/hertzbeat/pr-assets/nacos-ja-jp/.pr-assets/nacos-jajp-before.png)
   
   **After**
   
![after](https://raw.githubusercontent.com/orangeCatDeveloper/hertzbeat/pr-assets/nacos-ja-jp/.pr-assets/nacos-jajp-after.png)
   
   Files: `dynamic_tp`, `zookeeper`, `synology_nas`, `windows`, `kafka_client`, 
`tidb`, `nacos`, `hive`, `iceberg`, `springboot3`, `iotdb`, `jvm`, `spark`, 
`tomcat`.
   
   Verified with a full repo tag-balance re-scan (140 templates, 0 remaining 
issues), `YamlCheckScript`, and manual click-through of the add-monitor page in 
all 4 languages.
   
   ## Checklist
   
   - [x] I have read the [Contributing 
Guide](https://hertzbeat.apache.org/docs/community/code_style_and_quality_guide)
   - [x] I have written the necessary doc or comment.
   - [x] I have added the necessary unit tests and all cases have passed.
   
   ## Add or update API
   
   - [ ] I have added the necessary [e2e 
tests](https://github.com/apache/hertzbeat/tree/master/e2e) and all cases have 
passed.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to