yuluo-yx commented on code in PR #4055:
URL: https://github.com/apache/hertzbeat/pull/4055#discussion_r2901478201
##########
hertzbeat-common-core/src/main/java/org/apache/hertzbeat/common/entity/job/protocol/PrometheusProtocol.java:
##########
@@ -107,8 +112,28 @@ public static class Authorization {
@Override
public boolean isInvalid() {
+ if (!validateIpDomain(host) || !validPort(port)) {
Review Comment:
Other fields besides these should be optional configurations, therefore no
validation is included here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
