aiai-bot commented on PR #3963: URL: https://github.com/apache/hertzbeat/pull/3963#issuecomment-3744210708
<!-- code-pr-reviewer --> ## 🔴 Blocking Issues **Critical: Legacy data inaccessible** - `TdEngineDataStorage.java:360,419` - Queries use `_v2` tables but legacy data is in unsuffixed tables. Implement v1 fallback when v2 returns empty. - **No data migration path** - New `_v2` tables fragment user history with no migration tool. Provide migration scripts. **High Risk** - `TdEngineDataStorage.java:255` - SQL escaping via `"'"+ formatStringValue(instance) +"'"` may fail for quotes/backslashes. Add unit tests for special chars (`'`, `\`, `;`). - `TdEngineDataStorageTest.java` - All tests empty. No validation for string instances or v1/v2 compatibility. **Documentation** - Schema change needs upgrade guide, migration steps, and rollback instructions. Suggested tests: `mvn test -Dtest=TdEngineDataStorageTest` + manual v1.8.0 data upgrade verification. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
