AlexStocks commented on code in PR #658: URL: https://github.com/apache/dubbo-go-pixiu/pull/658#discussion_r2067733533
########## pkg/hotreload/route_reloader.go: ########## @@ -0,0 +1,140 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package hotreload + +import ( + "encoding/json" +) + +import ( + "github.com/pkg/errors" +) + +import ( + "github.com/apache/dubbo-go-pixiu/pkg/logger" + "github.com/apache/dubbo-go-pixiu/pkg/model" + "github.com/apache/dubbo-go-pixiu/pkg/server" +) + +// RouteReloader implements the HotReloader interface for reloading route configurations. +type RouteReloader struct{} + +// CheckUpdate compares the old and new route configurations to determine if a reload is needed. +func (r *RouteReloader) CheckUpdate(oldConfig, newConfig *model.Bootstrap) bool { + oldRoutes := extractRoutes(oldConfig) + newRoutes := extractRoutes(newConfig) + // Compare the number of routes + if len(oldRoutes.Routes) != len(newRoutes.Routes) || oldRoutes.Dynamic != newRoutes.Dynamic { + return true + } + + // Compare each route + for i := range newRoutes.Routes { + if oldRoutes.Routes[i].Match.Prefix != newRoutes.Routes[i].Match.Prefix || + oldRoutes.Routes[i].Route.Cluster != newRoutes.Routes[i].Route.Cluster { + return true + } + } + return false +} + +// HotReload applies the new route configuration. +func (r *RouteReloader) HotReload(oldConfig, newConfig *model.Bootstrap) error { + oldRoutes := extractRoutes(oldConfig) + newRoutes := extractRoutes(newConfig) + + // Update routes in the RouterManager + err := server.GetRouterManager().UpdateRoutes(oldRoutes.Routes, newRoutes.Routes) + if err != nil { + logger.Infof("Failed to Routes reloaded.") + return err + } + logger.Infof("Routes reloaded successfully.") Review Comment: 这个 log 要么不加，要加就更详细点，譬如什么类型的 route 加载成功 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
