ThisaraWeerakoon commented on code in PR #826:
URL: https://github.com/apache/dubbo-go-samples/pull/826#discussion_r2041062995
##########
llm/config/config.go:
##########
@@ -94,6 +95,17 @@ func Load(envFile string) (*Config, error) {
return
}
config.NacosURL = nacosURL
+ maxContextStr := os.Getenv("MAX_CONTEXT_COUNT")
+ if maxContextStr == "" {
+ config.MaxContextCount = 3 // Default to 3 for backward
compatibility
+ } else {
+ maxContext, err := strconv.Atoi(maxContextStr)
+ if err != nil {
+ configErr = fmt.Errorf("invalid
MAX_CONTEXT_COUNT value: %v", err)
+ return
+ }
+ config.MaxContextCount = maxContext
+ }
})
Review Comment:
> too much nest, and add a constant to represent the default value, like
this: if maxContextStr == "" { config.MaxContextCount = defaultMaxContextCount
return } maxContext, err := strconv.Atoi(maxContextStr) if err != nil {
configErr = fmt.Errorf("invalid MAX_CONTEXT_COUNT value: %v", err) return }
config.MaxContextCount = maxContext
Changes applied — refactored the logic and added the default constant. Let
me know if you have further suggestions! Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
