tiltwind commented on PR #375:
URL:
https://github.com/apache/dubbo-go-hessian2/pull/375#issuecomment-2788957022
@nuclearg 感谢
1. 有一个错误要解决
```
Error: decode_benchmark_test.go:54:2: ineffectual assignment to `now`
(ineffassign)
now = time.Now()
```
2. 测试和压测可以考虑改一下：
```
func TestMultipleLevelRecursiveDep(t *testing.T) {
// TODO : 测试 encode 和 decode 后的对象和源对象结构是一致的，值是相等的
}
func BenchmarkMultipleLevelRecursiveDep(b *testing.B) {
// TODO: 构造一个多层循环依赖的对象, 无需大对象， 压测情况大批量请求可以看出是否有性能改进
for i := 0; i < b.N; i++ {
// TODO : 循环 encode 和 decode
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
