FoghostCn commented on code in PR #2812:
URL: https://github.com/apache/dubbo-go/pull/2812#discussion_r2013479919
##########
common/url.go:
##########
@@ -779,6 +779,14 @@ func (c *URL) MergeURL(anotherUrl *URL) *URL {
// After Clone, it is a new URL that there is no thread safe issue.
mergedURL := c.Clone()
params := mergedURL.GetParams()
+ if params == nil {
+ mergedURL.paramsLock.Lock()
Review Comment:
no need to lock because mergedURL is a local variable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
