Re: [PR] FIX-15184 resolved NettyHttp Header add by set to empty String [dubbo]

Sun, 02 Mar 2025 00:01:25 -0800 


Stellar1999 commented on PR #15190:
URL: https://github.com/apache/dubbo/pull/15190#issuecomment-2692610203

   > Hi @Stellar1999, for version 3.3.3/3.4 the place where the error is 
happening 
(`org.apache.dubbo.rpc.protocol.tri.servlet.HttpMetadataAdapter.headers()#57`) 
looks like this as also mentioned in the original 
[issue](https://github.com/apache/dubbo/issues/15184): <img alt="Screenshot 
2025-03-02 at 15 46 35" width="827" 
src="https://private-user-images.githubusercontent.com/19259971/418329999-30f90806-9161-4b2d-8d3d-2df8b7451c78.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDA5MDI2MjYsIm5iZiI6MTc0MDkwMjMyNiwicGF0aCI6Ii8xOTI1OTk3MS80MTgzMjk5OTktMzBmOTA4MDYtOTE2MS00YjJkLThkM2QtMmRmOGI3NDUxYzc4LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAzMDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMzAyVDA3NTg0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTk0OWVjMjRiMWVkMTlmZWE0ZjkxYWJhNzRlMGQ2ZDQ2MDMzZGQ2MjllNW
 
ExYzY1YmQ5MjExYmI2ODRhNzUxY2YmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.OYZF63jpnDjbtsTBF_ec5opPphBzIHbiStDIVeIr_WA">
   > 
   > However, the same line in 3.3 looks like this: <img alt="Screenshot 
2025-03-02 at 15 47 16" width="682" 
src="https://private-user-images.githubusercontent.com/19259971/418330032-800e2068-6305-47d5-9bc8-9351eebf1f7b.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDA5MDI2MjYsIm5iZiI6MTc0MDkwMjMyNiwicGF0aCI6Ii8xOTI1OTk3MS80MTgzMzAwMzItODAwZTIwNjgtNjMwNS00N2Q1LTliYzgtOTM1MWVlYmYxZjdiLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAzMDIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMzAyVDA3NTg0NlomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTg3ZmU3MGVjM2U2NTdiYTQzOTM2MzdkMGQxZjIwMmNjZmVjM2ZjZmQ4MDVhNDAwOThiZWFmYThhNGFmY2JlZjEmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.z7XOb42WzIi0eu8ngcUfsF59x0NLoVHca9Cku0Yugeg";>
   > 
   > Since you mentioned that 3.3.3 will be merged to 3.3, shall i change in 
3.3 `request.getServerName()` to 
`request.getHeader(HttpHeaderNames.HOST.getName())` as how it's done in 3.3.3 & 
3.4?
   
   Oh, I see. I think this bug has already been fixed by PR 
[#15141](https://github.com/apache/dubbo/pull/15141). All we need to do now is 
merge 3.3 into 3.4. PTAL @zrlw @AlbumenJ 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to