strangelookingnerd commented on PR #14922: URL: https://github.com/apache/dubbo/pull/14922#issuecomment-2491436233
> Test locally first. Seems like I missed that one, sorry for that. However to me it seems like this test should have failed without my changes as well. I noticed that there is an exact copy of the failing test which has the assertion that is causing the issue here is commented out Comparing [dubbo-spring-boot/src/test/java/org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessorTest.java](https://github.com/strangelookingnerd/dubbo/blob/757dd4bfd73df36f9f9a85caa314a5b93a066efe/dubbo-spring-boot-project/dubbo-spring-boot/src/test/java/org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessorTest.java#L58) [dubbo-spring-boot-autoconfigure/src/test/java/org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessorTest](https://github.com/strangelookingnerd/dubbo/blob/757dd4bfd73df36f9f9a85caa314a5b93a066efe/dubbo-spring-boot-project/dubbo-spring-boot-autoconfigure/src/test/java/org/apache/dubbo/spring/boot/env/DubboDefaultPropertiesEnvironmentPostProcessorTest.java#L58) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
