Chenjp commented on PR #14432:
URL: https://github.com/apache/dubbo/pull/14432#issuecomment-2259605430

   @
   
   > > * move ApplicationModel (and sub-models) cleanup functions back to 
ApplicationModel#onDestroy
   > > * Fwk model level cleanup - to FrameworkModel#onDestroy
   > > * Runtime hook on process exit, shutdown dubbo engine gracefully: 
DubboShutdownHook supposed to do.
   > 
   > Agree
   
   @AlbumenJ  The latest commit passes local mvn test, but receives github 
actions failure ("10 successful, 8 failing, and 1 skipped checks "). Anything 
wrong i miss?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to