CrazyHZM commented on code in PR #14371:
URL: https://github.com/apache/dubbo/pull/14371#discussion_r1657181475
##########
dubbo-config/dubbo-config-spring/src/main/java/org/apache/dubbo/config/spring/ReferenceBean.java:
##########
@@ -423,15 +423,22 @@ private void generateFromJdk(List<Class<?>> interfaces) {
private Object getCallProxy() throws Exception {
if (referenceConfig == null) {
- referenceBeanManager.initReferenceBean(this);
- applicationContext
- .getBean(DubboConfigApplicationListener.class.getName(),
DubboConfigApplicationListener.class)
- .init();
- logger.warn(
- CONFIG_DUBBO_BEAN_INITIALIZER,
- "",
- "",
- "ReferenceBean is not ready yet, please make sure to call
reference interface method after dubbo is started.");
+ synchronized (LockUtils.getSingletonMutex(applicationContext)) {
Review Comment:
I'm worried that this will lead to low performance.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
