robin977 commented on code in PR #380:
URL: 
https://github.com/apache/dubbo-spi-extensions/pull/380#discussion_r1640747862


##########
dubbo-metadata-report-extensions/dubbo-metadata-report-etcd/src/main/java/org/apache/dubbo/metadata/store/etcd/EtcdMetadataReport.java:
##########
@@ -126,6 +126,16 @@ public String getServiceDefinition(MetadataIdentifier 
metadataIdentifier) {
         return etcdClient.getKVValue(getNodeKey(metadataIdentifier));
     }
 
+    @Override
+    public boolean registerServiceAppMapping(String key, String group, String 
content, Object ticket) {
+        String appKey = toRootDir() + "mapping-data" + PATH_SEPARATOR + key + 
PATH_SEPARATOR + group;
+        if (!etcdClient.put(appKey, content)) {

Review Comment:
   etcd3 transactions support cas



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to