CrazyHZM commented on code in PR #14106:
URL: https://github.com/apache/dubbo/pull/14106#discussion_r1628018217
##########
dubbo-common/src/main/java/org/apache/dubbo/common/event/DubboApplicationMulticasterRegistry.java:
##########
@@ -14,24 +14,29 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.dubbo.metrics;
+package org.apache.dubbo.common.event;
import org.apache.dubbo.common.beans.factory.ScopeBeanFactory;
-import org.apache.dubbo.metrics.event.MetricsDispatcher;
import org.apache.dubbo.rpc.model.ApplicationModel;
import org.apache.dubbo.rpc.model.FrameworkModel;
import org.apache.dubbo.rpc.model.ModuleModel;
import org.apache.dubbo.rpc.model.ScopeModelInitializer;
-public class MetricsScopeModelInitializer implements ScopeModelInitializer {
+/**
+ * Initialize {@link DubboLifecycleEventMulticaster} for {@link
ApplicationModel}
+ *
+ * @see DubboLifecycleEventMulticaster
+ * @since 3.3.0
+ */
+public class DubboApplicationMulticasterRegistry implements
ScopeModelInitializer {
Review Comment:
DubboApplicationMulticasterRegistry can have more specifications and make it
more general. DubboApplicationMulticasterRegistry needs to be re-named.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
