AlbumenJ commented on code in PR #14234:
URL: https://github.com/apache/dubbo/pull/14234#discussion_r1615442310
##########
dubbo-metadata/dubbo-metadata-report-redis/src/main/java/org/apache/dubbo/metadata/store/redis/RedisMetadataReport.java:
##########
@@ -133,7 +141,7 @@ private void storeMetadata(BaseMetadataIdentifier
metadataIdentifier, String v)
private void storeMetadataInCluster(BaseMetadataIdentifier
metadataIdentifier, String v) {
try (JedisCluster jedisCluster =
new JedisCluster(jedisClusterNodes, timeout, timeout, 2,
password, new GenericObjectPoolConfig<>())) {
- jedisCluster.set(metadataIdentifier.getIdentifierKey() +
META_DATA_STORE_TAG, v);
+ jedisCluster.set(metadataIdentifier.getIdentifierKey() +
META_DATA_STORE_TAG, v, jedisSetParams);
Review Comment:
I think this is a breaking change which means we are no longer support jedis
3.10.0. So, please patch to 3.3 branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
