YarBor commented on code in PR #287:
URL: https://github.com/apache/dubbo-kubernetes/pull/287#discussion_r1610922871
##########
pkg/admin/service/application.go:
##########
@@ -68,8 +84,77 @@ func GetApplicationTabInstanceInfo(rt core_runtime.Runtime,
req *model.Applicati
res := make([]*model.ApplicationTabInstanceInfoResp, 0,
len(dataplaneList.Items))
for _, dataplane := range dataplaneList.Items {
resItem := &model.ApplicationTabInstanceInfoResp{}
- res = append(res, resItem.FromDataplaneResource(dataplane))
+ resItem.FromDataplaneResource(dataplane)
+ resItem.GetRegistry(rt)
+ res = append(res, resItem)
}
return res, nil
}
+
+func GetApplicationServiceFormInfo(rt core_runtime.Runtime, req
*model.ApplicationServiceFormReq) ([]*model.ApplicationServiceFormResp, error) {
+ manager := rt.ResourceManager()
+ dataplaneList := &mesh.DataplaneResourceList{}
+ if err := manager.List(rt.AppContext(), dataplaneList,
store.ListByNameContains(req.AppName)); err != nil {
Review Comment:
dataplaneList := &mesh.DataplaneResourceList{}
why here do search but not use ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
