oxsean opened a new pull request, #14223: URL: https://github.com/apache/dubbo/pull/14223
## What is the purpose of the change HTTP/1 upgrade caused GET request to failed Case: https://github.com/apache/dubbo-samples/blob/master/2-advanced/dubbo-samples-triple-rest/dubbo-samples-triple-rest-springmvc/src/test/java/org/apache/dubbo/rest/demo/test/ConsumerIT.java#L47 ``` curl.exe -v --http2 http://127.0.0.1:50052/demo/hello?name=world ``` Expect 'Hello world' but respone empty body. ## Root cause [HttpServerUpgradeHandler.java#L377](https://github.com/netty/netty/blob/netty-4.1.109.Final/codec-http/src/main/java/io/netty/handler/codec/http/HttpServerUpgradeHandler.java#L377) already support write response, HttpServerAfterUpgradeHandler duplicate writes cause incorrect GET results. ## Brief changelog Remove unnecessary HttpServerAfterUpgradeHandler -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
