AlexStocks commented on code in PR #2680:
URL: https://github.com/apache/dubbo-go/pull/2680#discussion_r1605798379
##########
client/options.go:
##########
@@ -531,9 +531,9 @@ func (cliOpts *ClientOptions) init(opts ...ClientOption)
error {
type ClientOption func(*ClientOptions)
-func WithClientCheck() ClientOption {
+func WithClientNoCheck() ClientOption {
Review Comment:
> 这套 options 的 api 整体风格差不多就是枚举配置项，传参有点风格不一致
这个接口改动后，关键是会影响外部用户使用，所以我还是建议不要改名字，可以在注释上把函数的含义解释清楚。对外接口，不要轻易改动。
OR
把这个函数标记为 deprecated，重新实现一个新函数 WithClientNoCheck
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
