walkinggo commented on code in PR #14166:
URL: https://github.com/apache/dubbo/pull/14166#discussion_r1604847904
##########
dubbo-registry/dubbo-registry-zookeeper/src/main/java/org/apache/dubbo/registry/zookeeper/ZookeeperRegistry.java:
##########
@@ -201,7 +203,14 @@ public void doSubscribe(final URL url, final
NotifyListener listener) {
ChildListener zkListener =
ConcurrentHashMapUtils.computeIfAbsent(
listeners, listener, k -> (parentPath,
currentChildren) -> {
for (String child : currentChildren) {
- child = URL.decode(child);
+ try {
+ child = URL.decode(child);
+ if (!(JsonUtils.checkJson(child))) {
+ throw new Exception(child + "is not
json");
+ }
+ } catch (Exception e) {
+ logger.warn(PROTOCOL_ERROR_DESERIALIZE,
"", "", e.getMessage());
Review Comment:
should i output more information here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
