chickenlj commented on PR #2669: URL: https://github.com/apache/dubbo-go/pull/2669#issuecomment-2113787301
1. 监听的规则 key 应该是 provider 应用名，而不是当前进程自身应用名。可参考 tagrouter 的 notify 方法 2. 第1个逻辑改了后，Script Instance 实例的对应关系也要改一下，当前是全局共享的 3. 要确认下 dynamicconfuguration.AddListener() 的逻辑对不对（zookeeper/nacos），因为有多个 ScriptRouter 实例可能对应到一个 key (provider应用名)，dynamicconfuguration.AddListener()应该支持调用多次且记录多个listener --- zookeeper实现看起来没问题，nacos实现好像有问题。 4. instance.Compile 并发调用有没有问题 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
