aofall opened a new pull request, #14194: URL: https://github.com/apache/dubbo/pull/14194
## What is the purpose of the change 1. In the newer versions of Hibernate-validator, the package names of the relevant validation implementation classes have been migrated from `javax` to `jakarta`. Dubbo has been support new validator with jakarta in #9552 , but the setting of default validator is implement with javax, if the user is not configured to use a new validator under the SpringBoot3, an `NoClassDefFoundError` will be throw. If the validator supports automatic switch, this will reduce a lot of configuration processes for users. So Add an adapter that it can automatically switch. 2. If user fill in any characters into `dubbo.provider/consumer.validation` configuration that the validation extension not exists, the validation will active the default validator. But in the [official documentation](https://cn.dubbo.apache.org/zh-cn/overview/mannual/java-sdk/reference-manual/config/properties/) the parameter type of `dubbo.provider.validation` and `dubbo.consumer.validation` is described as Boolean, it's unexpect that user fill in the `false` parameter. Support disabling validation when parameter is 'false' that it is expected the description in document the parameter type is boolean ## Brief changelog 1. Add an adapter for javax and jakarta that it can automatically switch 2. Support disabling validation when parameter is 'false' that it is expected the description in document the parameter type is boolean ## Verifying this change <!-- Follow this checklist to help us incorporate your contribution quickly and easily: --> ## Checklist - [x] Make sure there is a [GitHub_issue](https://github.com/apache/dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GitHub issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Check if is necessary to patch to Dubbo 3 if you are work on Dubbo 2.7 - [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add sample in [dubbo samples](https://github.com/apache/dubbo-samples) project. - [ ] Add some description to [dubbo-website](https://github.com/apache/dubbo-website) project if you are requesting to add a feature. - [ ] GitHub Actions works fine on your own branch. - [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
