walklown commented on PR #14026: URL: https://github.com/apache/dubbo/pull/14026#issuecomment-2085120737
> LGTM, but have you tested no impact to dubbo protocol? And It would be good to place your test as a unit test in the Dubbo project, or you could put it in the integration tests as well: https://github.com/apache/dubbo-integration-cases Submitted some test cases to https://github.com/apache/dubbo-integration-cases/pull/22 1. Http2ClientT: Test on triple protocol to support other clients http1 to upgrade http2 2. DubboConsumerT: triple protocol and dubbo protocol RPC function testing, including turning on and off ssl -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
