chickenlj commented on code in PR #14035:
URL: https://github.com/apache/dubbo/pull/14035#discussion_r1574319311
##########
dubbo-compiler/src/main/resources/ReactorDubbo3TripleStub.mustache:
##########
@@ -54,6 +54,7 @@ public final class {{className}} {
private static final StubServiceDescriptor serviceDescriptor = new
StubServiceDescriptor(SERVICE_NAME,{{interfaceClassName}}.class);
static {
+
org.apache.dubbo.rpc.protocol.tri.service.SchemaDescriptorRegistry.addSchemaDescriptor(SERVICE_NAME,{{outerClassName}}.getDescriptor());
Review Comment:
@caoyanan666 What if user does not set `outClassName` in his `.proto` file.
##########
dubbo-compiler/src/main/resources/ReactorDubbo3TripleStub.mustache:
##########
@@ -54,6 +54,7 @@ public final class {{className}} {
private static final StubServiceDescriptor serviceDescriptor = new
StubServiceDescriptor(SERVICE_NAME,{{interfaceClassName}}.class);
static {
+
org.apache.dubbo.rpc.protocol.tri.service.SchemaDescriptorRegistry.addSchemaDescriptor(SERVICE_NAME,{{outerClassName}}.getDescriptor());
Review Comment:
@caoyanan666 What if user does not set `outClassName` in his `.proto` file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]