DMwangnima commented on code in PR #2648:
URL: https://github.com/apache/dubbo-go/pull/2648#discussion_r1564410215
##########
client/client.go:
##########
@@ -59,7 +59,8 @@ func (conn *Connection) call(ctx context.Context, reqs
[]interface{}, resp inter
if err != nil {
return nil, err
}
- return conn.refOpts.invoker.Invoke(ctx, inv), nil
+ res := conn.refOpts.invoker.Invoke(ctx, inv)
Review Comment:
It seems there is no need to change statement style.
##########
protocol/triple/triple_invoker.go:
##########
@@ -136,36 +143,50 @@ func (ti *TripleInvoker) Invoke(ctx context.Context,
invocation protocol.Invocat
return &result
}
+func mergeAttachmentToOutgoing(ctx context.Context, attachments
map[string]interface{}) (context.Context, error) {
Review Comment:
Since you extract attachments merge logic from ```parseInvocation```. Why do
not extract entire logics about processing attachments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
