walklown commented on issue #14015: URL: https://github.com/apache/dubbo/issues/14015#issuecomment-2053667103
MetricsExport is used to obtain metric information, while MetricsReporter is similar to Register in micrometer. First of all, which part of the current Issue is aimed at optimizing? And then, I have some optimization suggestions for MetricsExport and MetricsCollector, such as: 1. Disassemble CombMetricsCollector. ApplicationMetricsCollector<E>, ServiceMetricsCollector<E>, MethodMetricsCollector<E> The binding of the three methods to MetricsKey can exist in Function mode. Now all Collectors must inherit CombMetricsCollector, which is strange. 2. Split MetricsCollector and MetricsListener. They are different objects. 3. Consider adjusting the implementation classes of BaseStatComposite and each MetricsExport. These implementation classes are now only related to indicator classification, which is very unfavorable for expansion. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
