BitoAgent commented on code in PR #13786:
URL: https://github.com/apache/dubbo/pull/13786#discussion_r1538250545
##########
dubbo-remoting/dubbo-remoting-http12/src/main/java/org/apache/dubbo/remoting/http12/message/LengthFieldStreamingDecoder.java:
##########
@@ -20,7 +20,6 @@
import org.apache.dubbo.remoting.http12.exception.DecodeException;
import java.io.ByteArrayInputStream;
-import java.io.ByteArrayOutputStream;
import java.io.IOException;
Review Comment:
**Security Issue**: The removal of 'import java.io.ByteArrayOutputStream;'
indicates that 'ByteArrayOutputStream' is no longer used in
'LengthFieldStreamingDecoder'. This cleanup helps in maintaining the clarity of
the codebase and ensures that unused imports do not clutter the code. It is a
good practice to remove unused imports to improve code readability and slightly
reduce the memory footprint. <br> **Fix**: No specific action required for
security, but ensure that the removal of unused imports is part of regular code
maintenance. <br> **Code Suggestion**:
```
Since 'ByteArrayOutputStream' is no longer used in
'LengthFieldStreamingDecoder.java', ensure to remove any unused imports to
maintain code clarity.
-import java.io.ByteArrayOutputStream;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
