chickenlj commented on code in PR #1061: URL: https://github.com/apache/dubbo-samples/pull/1061#discussion_r1527695380
########## 2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/dubbo-servicediscovery-migration-provider2/src/main/resources/dubbo.properties: ########## @@ -1,2 +0,0 @@ -dubbo.application.qos.port=22222 -dubbo.application.register-mode=instance Review Comment: `dubbo.application.register-mode=instance` is missed in `application.yml` ########## 2-advanced/dubbo-samples-service-discovery/dubbo-servicediscovery-migration/dubbo-servicediscovery-migration-provider1/src/main/resources/dubbo.properties: ########## @@ -1,2 +0,0 @@ -dubbo.application.qos.port=22222 -dubbo.application.register-mode=interface Review Comment: `dubbo.application.register-mode=interface` is missed in `application.yml` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
