DMwangnima commented on code in PR #725: URL: https://github.com/apache/dubbo-go-samples/pull/725#discussion_r1525689519
########## multirpc/go-client/cmd/main.go: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package main + +import ( + "context" + "dubbo.apache.org/dubbo-go/v3" + "dubbo.apache.org/dubbo-go/v3/client" + "dubbo.apache.org/dubbo-go/v3/common/constant" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/registry" + greet "github.com/apache/dubbo-go-samples/multirpc/proto" + "github.com/dubbogo/gost/log/logger" +) + +func main() { + ins, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_triple_client"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + //test triple + cliTriple, err := ins.NewClient( + client.WithClientProtocolTriple(), + ) + if err != nil { + panic(err) + } + svc, err := greet.NewGreetService(cliTriple) + if err != nil { + panic(err) + } + + resp, err := svc.Greet(context.Background(), &greet.GreetRequest{Name: "hello world"}) + if err != nil { + logger.Error(err) + } + logger.Infof("Greet multirpc response: %s", resp) + + //test dubbo + ins_dubbo, err := dubbo.NewInstance( Review Comment: Actually, ```dubbo.Instance``` is global conception. Init once is okay. ########## multirpc/go-client/cmd/main.go: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package main + +import ( + "context" + "dubbo.apache.org/dubbo-go/v3" + "dubbo.apache.org/dubbo-go/v3/client" + "dubbo.apache.org/dubbo-go/v3/common/constant" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/registry" + greet "github.com/apache/dubbo-go-samples/multirpc/proto" + "github.com/dubbogo/gost/log/logger" +) + +func main() { + ins, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_triple_client"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + //test triple + cliTriple, err := ins.NewClient( Review Comment: In this scenario, a client would create multi connections. So we just need to configure protocol with ```WithXXX``` in Reference layer. ########## multirpc/go-server/cmd/main.go: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package main + +import ( + "context" + + "dubbo.apache.org/dubbo-go/v3" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/protocol" + "dubbo.apache.org/dubbo-go/v3/registry" + "dubbo.apache.org/dubbo-go/v3/server" + greet "github.com/apache/dubbo-go-samples/multirpc/proto" + "github.com/dubbogo/gost/log/logger" +) + +type GreetMultiRPCServer struct { +} + +func (srv *GreetMultiRPCServer) Greet(ctx context.Context, req *greet.GreetRequest) (*greet.GreetResponse, error) { + resp := &greet.GreetResponse{Greeting: req.Name} + return resp, nil +} + +func main() { + ins, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_server"), Review Comment: For configuring multiple protocols in server side, please refer to ```dubbo.WithProtocol```. You should inject 3 ```dubbo.WithProtocol``` here. ########## multirpc/go-client/cmd/main.go: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package main + +import ( + "context" + "dubbo.apache.org/dubbo-go/v3" + "dubbo.apache.org/dubbo-go/v3/client" + "dubbo.apache.org/dubbo-go/v3/common/constant" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/registry" + greet "github.com/apache/dubbo-go-samples/multirpc/proto" + "github.com/dubbogo/gost/log/logger" +) + +func main() { + ins, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_triple_client"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + //test triple + cliTriple, err := ins.NewClient( + client.WithClientProtocolTriple(), + ) + if err != nil { + panic(err) + } + svc, err := greet.NewGreetService(cliTriple) + if err != nil { + panic(err) + } + + resp, err := svc.Greet(context.Background(), &greet.GreetRequest{Name: "hello world"}) + if err != nil { + logger.Error(err) + } + logger.Infof("Greet multirpc response: %s", resp) + + //test dubbo + ins_dubbo, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_dubbo_client"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + cli_dubbo, err := ins_dubbo.NewClient( + client.WithClientProtocolDubbo(), + client.WithClientSerialization(constant.Hessian2Serialization), + ) + if err != nil { + panic(err) + } + + connDubbo, err := cli_dubbo.Dial("GreetProvider") Review Comment: Configure ```WithProtocolDubbo``` here. ########## multirpc/go-client/cmd/main.go: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package main + +import ( + "context" + "dubbo.apache.org/dubbo-go/v3" + "dubbo.apache.org/dubbo-go/v3/client" + "dubbo.apache.org/dubbo-go/v3/common/constant" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/registry" + greet "github.com/apache/dubbo-go-samples/multirpc/proto" + "github.com/dubbogo/gost/log/logger" +) + +func main() { + ins, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_triple_client"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + //test triple + cliTriple, err := ins.NewClient( + client.WithClientProtocolTriple(), + ) + if err != nil { + panic(err) + } + svc, err := greet.NewGreetService(cliTriple) + if err != nil { + panic(err) + } + + resp, err := svc.Greet(context.Background(), &greet.GreetRequest{Name: "hello world"}) + if err != nil { + logger.Error(err) + } + logger.Infof("Greet multirpc response: %s", resp) + + //test dubbo + ins_dubbo, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_dubbo_client"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + cli_dubbo, err := ins_dubbo.NewClient( + client.WithClientProtocolDubbo(), + client.WithClientSerialization(constant.Hessian2Serialization), + ) + if err != nil { + panic(err) + } + + connDubbo, err := cli_dubbo.Dial("GreetProvider") + if err != nil { + panic(err) + } + var respDubbo string + if err := connDubbo.CallUnary(context.Background(), []interface{}{"hello", "new", "dubbo"}, &respDubbo, "Greet"); err != nil { + logger.Errorf("GreetProvider.Greet err: %s", err) + return + } + logger.Infof("Get Response: %s", respDubbo) + + //test json rpc Review Comment: For jsonrpc part, ditto. ########## multirpc/go-client/cmd/main.go: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package main + +import ( + "context" + "dubbo.apache.org/dubbo-go/v3" + "dubbo.apache.org/dubbo-go/v3/client" + "dubbo.apache.org/dubbo-go/v3/common/constant" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/registry" + greet "github.com/apache/dubbo-go-samples/multirpc/proto" + "github.com/dubbogo/gost/log/logger" +) + +func main() { + ins, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_triple_client"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + //test triple + cliTriple, err := ins.NewClient( + client.WithClientProtocolTriple(), + ) + if err != nil { + panic(err) + } + svc, err := greet.NewGreetService(cliTriple) + if err != nil { + panic(err) + } + + resp, err := svc.Greet(context.Background(), &greet.GreetRequest{Name: "hello world"}) + if err != nil { + logger.Error(err) + } + logger.Infof("Greet multirpc response: %s", resp) Review Comment: You can change it to "Greet multirpc triple response: %s" for clarity. ########## multirpc/go-server/cmd/main.go: ########## @@ -0,0 +1,68 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package main + +import ( + "context" + + "dubbo.apache.org/dubbo-go/v3" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/protocol" + "dubbo.apache.org/dubbo-go/v3/registry" + "dubbo.apache.org/dubbo-go/v3/server" + greet "github.com/apache/dubbo-go-samples/multirpc/proto" + "github.com/dubbogo/gost/log/logger" +) + +type GreetMultiRPCServer struct { +} + +func (srv *GreetMultiRPCServer) Greet(ctx context.Context, req *greet.GreetRequest) (*greet.GreetResponse, error) { + resp := &greet.GreetResponse{Greeting: req.Name} + return resp, nil +} + +func main() { + ins, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_server"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + srv, err := ins.NewServer( + server.WithServerProtocol( + protocol.WithDubbo(), Review Comment: If you take a look at ```protocol.WithDubbo() protocol.WithTriple() ...```, you will find that only the last one would take effect. You should refer to ```server.WithProtocolIDs```. ########## multirpc/go-client/cmd/main.go: ########## @@ -0,0 +1,119 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package main + +import ( + "context" + "dubbo.apache.org/dubbo-go/v3" + "dubbo.apache.org/dubbo-go/v3/client" + "dubbo.apache.org/dubbo-go/v3/common/constant" + _ "dubbo.apache.org/dubbo-go/v3/imports" + "dubbo.apache.org/dubbo-go/v3/registry" + greet "github.com/apache/dubbo-go-samples/multirpc/proto" + "github.com/dubbogo/gost/log/logger" +) + +func main() { + ins, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_triple_client"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + //test triple + cliTriple, err := ins.NewClient( + client.WithClientProtocolTriple(), + ) + if err != nil { + panic(err) + } + svc, err := greet.NewGreetService(cliTriple) + if err != nil { + panic(err) + } + + resp, err := svc.Greet(context.Background(), &greet.GreetRequest{Name: "hello world"}) + if err != nil { + logger.Error(err) + } + logger.Infof("Greet multirpc response: %s", resp) + + //test dubbo + ins_dubbo, err := dubbo.NewInstance( + dubbo.WithName("dubbo_multirpc_dubbo_client"), + dubbo.WithRegistry( + registry.WithZookeeper(), + registry.WithAddress("127.0.0.1:2181"), + ), + ) + if err != nil { + panic(err) + } + cli_dubbo, err := ins_dubbo.NewClient( + client.WithClientProtocolDubbo(), + client.WithClientSerialization(constant.Hessian2Serialization), + ) + if err != nil { + panic(err) + } + + connDubbo, err := cli_dubbo.Dial("GreetProvider") + if err != nil { + panic(err) + } + var respDubbo string + if err := connDubbo.CallUnary(context.Background(), []interface{}{"hello", "new", "dubbo"}, &respDubbo, "Greet"); err != nil { + logger.Errorf("GreetProvider.Greet err: %s", err) + return + } + logger.Infof("Get Response: %s", respDubbo) Review Comment: ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
