Lvnszn commented on code in PR #106:
URL: https://github.com/apache/dubbo-getty/pull/106#discussion_r1522727499
##########
session.go:
##########
@@ -631,6 +632,16 @@ func (s *session) handleTCPPackage() error {
pktBuf = gxbytes.NewBuffer(nil)
conn = s.Connection.(*gettyTCPConn)
+ if tlsConn, ok := conn.conn.(*tls.Conn); ok {
+ tlsHandshaketime := defaultTLSHandshakeTimeout
+ if s.ReadTimeout() > 0 {
Review Comment:
dubbo-go will set 1s by default, so it is recommended to use readTime first.
If it is equal to 0, use the default 3s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
