justxuewei commented on code in PR #2609:
URL: https://github.com/apache/dubbo-go/pull/2609#discussion_r1515593631
##########
cmd/protoc-gen-go-triple/go.mod:
##########
@@ -1,11 +1,14 @@
module dubbo.apache.org/dubbo-go/v3/cmd/protoc-gen-go-triple
-go 1.15
+go 1.22.1
Review Comment:
Ditto.
##########
.github/workflows/golangci-lint.yml:
##########
@@ -18,15 +18,15 @@ jobs:
strategy:
matrix:
golang:
- - 1.17
+ - 1.22.1
steps:
- uses: actions/setup-go@v3
with:
- go-version: 1.17
+ go-version: 1.22.1
Review Comment:
Ditto.
##########
.github/workflows/github-actions.yml:
##########
@@ -20,7 +20,7 @@ jobs:
# If you want to matrix build , you can append the following list.
matrix:
go_version:
- - 1.17
+ - 1.22.1
Review Comment:
No need to privode patch version.
```suggestion
- 1.22
```
##########
.github/workflows/golangci-lint.yml:
##########
@@ -18,15 +18,15 @@ jobs:
strategy:
matrix:
golang:
- - 1.17
+ - 1.22.1
Review Comment:
Ditto.
##########
.github/workflows/github-actions.yml:
##########
@@ -20,7 +20,7 @@ jobs:
# If you want to matrix build , you can append the following list.
matrix:
go_version:
- - 1.17
+ - 1.22.1
Review Comment:
Plus, we could add latest three versions, `1.20`, `1.21` and `1.22` at this
moment, on account of compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
