JoeCqupt commented on code in PR #13781:
URL: https://github.com/apache/dubbo/pull/13781#discussion_r1500318159
##########
dubbo-common/src/main/java/org/apache/dubbo/common/config/ModuleEnvironment.java:
##########
@@ -94,19 +92,13 @@ public List<Map<String, String>>
getConfigurationMaps(AbstractConfig config, Str
@Override
public Configuration getDynamicGlobalConfiguration() {
if (dynamicConfiguration == null) {
- return applicationDelegate.getDynamicGlobalConfiguration();
+ CompositeConfiguration configuration = new
CompositeConfiguration();
+
configuration.addConfiguration(applicationDelegate.getDynamicGlobalConfiguration());
+ configuration.addConfiguration(orderedPropertiesConfiguration);
+ return configuration;
}
+
if (dynamicGlobalConfiguration == null) {
- if (dynamicConfiguration == null) {
Review Comment:
This situation has already been handled, here is unnecessary code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
