CrazyHZM commented on code in PR #1043:
URL: https://github.com/apache/dubbo-samples/pull/1043#discussion_r1498746794
##########
2-advanced/dubbo-samples-native-image-registry/dubbo-samples-native-image-registry-consumer/pom.xml:
##########
@@ -258,6 +277,88 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>nativeTest</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.1.2</version>
+ <configuration>
+ <includes>
+ <include>${env.TEST_PATTERNS}</include>
+ </includes>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-maven-plugin</artifactId>
+ <version>${spring-boot.version}</version>
+ <executions>
+ <execution>
+ <id>process-test-aot</id>
+ <goals>
+ <goal>process-test-aot</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-maven-plugin</artifactId>
+ <version>${dubbo.version}</version>
+ <executions>
+ <execution>
+ <id>dubbo-process-test-aot</id>
+ <phase>process-test-sources</phase>
+ <goals>
+ <goal>dubbo-process-aot</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>dubbo-process-test-aot-classes</id>
+ <phase>process-test-classes</phase>
+ <goals>
+ <goal>dubbo-process-aot</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <mainClass>placeholder_avoid_error</mainClass>
<!-- https://github.com/apache/dubbo/pull/13426 -->
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.graalvm.buildtools</groupId>
+ <artifactId>native-maven-plugin</artifactId>
+ <version>0.9.28</version>
Review Comment:
Version can be upgraded.
##########
2-advanced/dubbo-samples-native-image-registry/dubbo-samples-native-image-registry-consumer/pom.xml:
##########
@@ -258,6 +277,88 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>nativeTest</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.1.2</version>
+ <configuration>
+ <includes>
+ <include>${env.TEST_PATTERNS}</include>
+ </includes>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-maven-plugin</artifactId>
+ <version>${spring-boot.version}</version>
+ <executions>
+ <execution>
+ <id>process-test-aot</id>
+ <goals>
+ <goal>process-test-aot</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-maven-plugin</artifactId>
+ <version>${dubbo.version}</version>
+ <executions>
+ <execution>
+ <id>dubbo-process-test-aot</id>
+ <phase>process-test-sources</phase>
+ <goals>
+ <goal>dubbo-process-aot</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>dubbo-process-test-aot-classes</id>
+ <phase>process-test-classes</phase>
+ <goals>
+ <goal>dubbo-process-aot</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <mainClass>placeholder_avoid_error</mainClass>
<!-- https://github.com/apache/dubbo/pull/13426 -->
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.graalvm.buildtools</groupId>
+ <artifactId>native-maven-plugin</artifactId>
+ <version>0.9.28</version>
Review Comment:
I suggest that it can also be managed by case-version.conf
##########
2-advanced/dubbo-samples-native-image-registry/dubbo-samples-native-image-registry-consumer/pom.xml:
##########
@@ -258,6 +277,88 @@
</plugins>
</build>
</profile>
+ <profile>
+ <id>nativeTest</id>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.maven.plugins</groupId>
+ <artifactId>maven-surefire-plugin</artifactId>
+ <version>3.1.2</version>
+ <configuration>
+ <includes>
+ <include>${env.TEST_PATTERNS}</include>
+ </includes>
+ </configuration>
+ </plugin>
+ <plugin>
+ <groupId>org.springframework.boot</groupId>
+ <artifactId>spring-boot-maven-plugin</artifactId>
+ <version>${spring-boot.version}</version>
+ <executions>
+ <execution>
+ <id>process-test-aot</id>
+ <goals>
+ <goal>process-test-aot</goal>
+ </goals>
+ </execution>
+ </executions>
+ </plugin>
+ <plugin>
+ <groupId>org.apache.dubbo</groupId>
+ <artifactId>dubbo-maven-plugin</artifactId>
+ <version>${dubbo.version}</version>
+ <executions>
+ <execution>
+ <id>dubbo-process-test-aot</id>
+ <phase>process-test-sources</phase>
+ <goals>
+ <goal>dubbo-process-aot</goal>
+ </goals>
+ </execution>
+ <execution>
+ <id>dubbo-process-test-aot-classes</id>
+ <phase>process-test-classes</phase>
+ <goals>
+ <goal>dubbo-process-aot</goal>
+ </goals>
+ </execution>
+ </executions>
+ <configuration>
+ <mainClass>placeholder_avoid_error</mainClass>
<!-- https://github.com/apache/dubbo/pull/13426 -->
Review Comment:
Is this required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
