MajaChen commented on PR #13617: URL: https://github.com/apache/dubbo/pull/13617#issuecomment-1890329189
I add a new method parseAcceptCharset, it can deal with multi values related with Accept-Charset. It worked well as demonstrated by unit test. I think it's ok to take the charset with the biggest weight alone. I'm doubtful whether these code have pratical function in most case. As Accept-Charset is not recommended to use. Most importantly, OkhttpClient don't take Accept-Charset into consideration when encoding url,see: builder.url(requestTemplate.getURL()); (OKHttpRestClient.java line 55) But I still think adding Accept-Charset make code more rigorous and compatible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
