FinalT commented on code in PR #2563:
URL: https://github.com/apache/dubbo-go/pull/2563#discussion_r1441675925
##########
metadata/report/nacos/report.go:
##########
@@ -91,10 +101,10 @@ func (n *nacosMetadataReport)
PublishAppMetadata(metadataIdentifier *identifier.
if err != nil {
return err
}
-
+ // same with java impl
return n.storeMetadata(vo.ConfigParam{
- DataId: metadataIdentifier.GetIdentifierKey(),
- Group: n.group,
+ DataId: metadataIdentifier.Application,
+ Group: metadataIdentifier.Revision,
Content: string(data),
})
Review Comment:
We need to adapt the previous rules here
##########
metadata/report/nacos/report.go:
##########
@@ -91,10 +101,10 @@ func (n *nacosMetadataReport)
PublishAppMetadata(metadataIdentifier *identifier.
if err != nil {
return err
}
-
+ // same with java impl
return n.storeMetadata(vo.ConfigParam{
- DataId: metadataIdentifier.GetIdentifierKey(),
- Group: n.group,
+ DataId: metadataIdentifier.Application,
+ Group: metadataIdentifier.Revision,
Content: string(data),
})
Review Comment:
Otherwise, the previous service will not be able to call the current service
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
