ev1lQuark commented on code in PR #113: URL: https://github.com/apache/dubbo-kubernetes/pull/113#discussion_r1437565217
########## pkg/admin/constant/kubenetes.go: ########## @@ -0,0 +1,25 @@ +package constant + +const baseLabel = "dubbo.io" + +const ( + ApplicationLabel = baseLabel + "/application" + ServiceKeyLabel = baseLabel + "/serviceKey" + GroupLabel = baseLabel + "/group" + VersionLabel = baseLabel + "/version" Review Comment: The label name and base prefix should be synchronized with the "best practices" in the documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
