chickenlj commented on issue #122:
URL: 
https://github.com/apache/dubbo-kubernetes/issues/122#issuecomment-1869302010

   > // RegisterService 注册服务
   > RegisterService(ctx *context.Context, service Service) error
   > // UnregisterService 注销服务
   > UnregisterService(ctx *context.Context, service Service) error
   > // GetServiceByRule 根据路由规则获取服务
   > GetServiceByRule(ctx *context.Context, serviceName string, rule Rule) 
(Service, error)
   
   These three methods can be removed.
   
   > ```
   > type Rule interface {
   >    // GetConfigVersion 获取配置版本号
   >    GetConfigVersion(ctx *context.Context) string
   >    // GetRuleType 获取路由规则类型
   >    GetRuleType(ctx *context.Context) string
   >    // GetRouteRule 获取路由规则
   >    GetRouteRule(ctx *context.Context) string
   >    // SetRouteRule 设置路由规则,有条件路由\标签路由\脚本路由\动态配置路由
   >    SetRouteRule(ctx *context.Context, rule interface{}) error
   > }
   > ```
   
   Rule-related methods should also has parameters like `serviceName` and 
`ruleType`: `GetRuleType(ctx *context.Context, serviceName string, ruleType 
RuleType) string`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to