yuluo-yx commented on code in PR #116:
URL: https://github.com/apache/dubbo-kubernetes/pull/116#discussion_r1431431340


##########
release/downloadDubbo.sh:
##########
@@ -25,7 +25,7 @@ fi
 
 # Determine the latest Dubbo version by version number ignoring alpha, beta, 
and rc versions.
 if [ "${DUBBO_VERSION}" = "" ] ; then
-  DUBBO_VERSION="$(curl -sL 
https://github.com/dawnzzz/dubbo-kubernetes/releases | \
+  DUBBO_VERSION="$(curl -sL https://github.com/apache/dubbo/releases | \

Review Comment:
   The name of this script is downloadDubbo.sh. This is how downloadDuboctl.sh 
is configured.
   
   In other words, we only need one script to complete the work of downloading 
dubbo, dubboctl, and dubbo-cp, instead of two scripts.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to