chickenlj commented on code in PR #2502:
URL: https://github.com/apache/dubbo-go/pull/2502#discussion_r1393532440
##########
client/client.go:
##########
@@ -45,7 +47,7 @@ type ClientInfo struct {
Meta map[string]interface{}
}
-func (cli *Client) call(ctx context.Context, paramsRawVals []interface{},
interfaceName, methodName, callType string, opts ...CallOption)
(protocol.Result, error) {
+func (cli *Client) call(ctx context.Context, paramsRawVals []interface{},
interfaceName, methodName, group, version, callType string, opts ...CallOption)
(protocol.Result, error) {
Review Comment:
Good point. I was also thinking of using CallOption in the first place. I
will move group and version to CallOption later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
