AlbumenJ commented on code in PR #13347:
URL: https://github.com/apache/dubbo/pull/13347#discussion_r1392455590
##########
dubbo-config/dubbo-config-api/src/main/java/org/apache/dubbo/config/deploy/DefaultApplicationDeployer.java:
##########
@@ -779,6 +780,13 @@ public void prepareApplicationInstance(ModuleModel
moduleModel) {
// export MetricsService
exportMetricsService();
+ if (moduleModel.getDeployer().hasRegistryInteraction()) {
+ ApplicationConfig applicationConfig =
configManager.getApplicationOrElseThrow();
+ if (DEFAULT_APP_NAME.equals(applicationConfig.getName())) {
+ throw new IllegalStateException("Application name must be set
when registry is enabled.");
+ }
Review Comment:
I think it would be better to allow register interface mode if users have
not specified the application name. It works in interface mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
