DMwangnima commented on code in PR #2456:
URL: https://github.com/apache/dubbo-go/pull/2456#discussion_r1374145657
##########
common/constant/key.go:
##########
@@ -19,6 +19,8 @@ package constant
type DubboCtxKey string
+type TripleCtxKey string
Review Comment:
I suggest that moving this type to
protocol/triple/triple_protocol/handler_compat.go since Triple protocol should
try not to rely on dubbo-go as much as possible.
##########
common/constant/key.go:
##########
@@ -434,3 +436,8 @@ const (
DefaultMetaFileName = "dubbo.metadata."
DefaultEntrySize = 100
)
+
Review Comment:
Ditto.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
