DMwangnima commented on code in PR #2450:
URL: https://github.com/apache/dubbo-go/pull/2450#discussion_r1367063182
##########
protocol/triple/triple-tool/gen/generator/tripleTpl_test.go:
##########
@@ -319,24 +332,24 @@ type GreetService_GreetClient interface {
Close() error
}
-type greetServiceGreetClient struct {
+type GreetServiceGreetClient struct {
Review Comment:
Is **GreetService_GreetClient** redundant? There is no need to use this
interface.
##########
protocol/triple/triple-tool/gen/generator/tripleTpl_test.go:
##########
@@ -452,22 +465,22 @@ type GreetServiceHandler interface {
}
-func ProvideGreetServiceHandler(pro *provider.Provider, hdlr
GreetServiceHandler) error {
- return pro.Provide(hdlr, &GreetService_ServiceInfo)
+func RegisterGreetServiceHandler(srv *server.Server, hdlr GreetServiceHandler,
opts ...server.ServiceOption) error {
+ return srv.Register(hdlr, &GreetService_ServiceInfo, opts...)
}
type GreetService_GreetServer interface {
- Send(*proto.GreetServerStreamResponse) error
+ Send(*proto.GreetResponse) error
Review Comment:
The problem with **GreetService_GreetServer** is the same as
**GreetService_GreetClient**.
##########
protocol/triple/triple-tool/gen/generator/tripleTpl_test.go:
##########
@@ -186,26 +186,30 @@ service GreetService {
const testTripleGo = `// Code generated by protoc-gen-triple. DO NOT EDIT.
//
// Source:
-package greettriple
+package greet
Review Comment:
Why change package name from **greettriple** to **greet**?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
