chickenlj commented on code in PR #2447: URL: https://github.com/apache/dubbo-go/pull/2447#discussion_r1356663291
########## logger/options.go: ########## @@ -0,0 +1,137 @@ +/* Review Comment: I will replace these methods with some more generic methods instead. I did check all the possible values of each type, and they seems to very limited as I listed according to the implementation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
