SpringStudent commented on code in PR #13155:
URL: https://github.com/apache/dubbo/pull/13155#discussion_r1349637681
##########
dubbo-rpc/dubbo-rpc-triple/src/test/java/org/apache/dubbo/rpc/protocol/tri/TripleProtocolTest.java:
##########
@@ -45,6 +43,19 @@
class TripleProtocolTest {
+ @Test
+ void testPbMethodOverride()throws Exception{
Review Comment:
> The test should not be here, I think the test constructor
ReflectionServiceDescriptor is better
In beginning i want to write test case in
dubbo-common/ReflectionServiceDescriptorTest.java,but the project which
contains ReflectionServiceDescriptor.java code did't have protobuf
dependencies,So I cannot add pb class for this unit test.Whether it is
necessary add protobuf denpendices to dubbo-common pom.xml.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
