lizining1231 commented on code in PR #3746: URL: https://github.com/apache/dubbo-go/pull/3746#discussion_r4063820812
########## protocol/triple/triple_protocol/option.go: ########## Review Comment: 感谢指出，的确冗余 快速路径现在默认开启，所以`WithUnaryFastPath()` 的`applyToClient` 只是把默认值又写了一遍。它本身是当时写快速路径 默认关闭时候的设计后来默认值翻成`true` 之后，`With` 这一侧就退化成显式声明，只剩`Without` 还可以真正改变行为 当前已把这一侧删掉了，同时补了一条`TestUnaryFastPathEnabledByDefault` 钉住默认值，避免以后默认值再变时基准静默测偏。不在本 PR 的改动范围内，diff不大，约60+，我会提个issue跟进 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
