AsperforMias opened a new pull request, #3743: URL: https://github.com/apache/dubbo-go/pull/3743
### Description This is part of #3562 (Admin Trace → Metric field alignment). Related to #3723. @dodjdnh this implements the Admin P0 Trace → Metric mapping you described in https://github.com/apache/dubbo-go/issues/3562#issuecomment-5598910584 and https://github.com/apache/dubbo-go/pull/3551#issuecomment-5599002500. **Problem.** Server and Client OTel filters currently set `rpc.service` from `URL.ServiceKey()`, which becomes `group/interface:version` when group/version are configured. Prometheus RPC metrics already use `URL.Service()` for the `interface` label. Dubbo Admin cannot stably map Trace `rpc.service` to Metric `interface`. **Change.** In `filter/otel/trace/filter.go`, `rpc.service` now uses `URL.Service()` (interface FQDN, with Path fallback) on both the provider and consumer filters. Public `URL.ServiceKey()` is unchanged. After this change, with `group=gray` and `version=1.0.0`: ```text Trace rpc.service = org.apache.dubbo.samples.OrderService Metric interface = org.apache.dubbo.samples.OrderService ``` **Tests.** Provider and Consumer span tests cover group/version and Path fallback, and assert `rpc.service == URL.Service()` while `rpc.service != URL.ServiceKey()`. Metric label tests assert `interface` is not the composite service key. **Out of scope (phase 1).** Span name changes. Independent `dubbo.group` / `dubbo.version` span attributes. **Overlap.** Draft #3551 also touches `filter/otel/trace/filter.go` and currently still uses `ServiceKey()` for `rpc.service`. #3724 already landed the same `rpc.service` correction (plus independent group/version attributes) on `develop`. This PR is the Admin P0 field correction on `main`. ### Checklist - [x] I confirm the target branch is `main` - [x] I have run `make fmt` to format my code - [x] I have run `make test` to run local tests - [x] I have added tests that prove my fix is effective or that my feature works -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
