Tsukikage7 commented on PR #3551: URL: https://github.com/apache/dubbo-go/pull/3551#issuecomment-5600396863
One detail from checking the metrics implementation: the `interface` label already uses `url.Service()`, so I suggest reusing that for `rpc.service` to keep both signals aligned. The new tests currently expect the combined group/interface/version service key and would need to change as well. I’m happy to review the update against the Admin mapping requirements. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
